feat: support microflow download file statement#333
Open
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Open
feat: support microflow download file statement#333hjotha wants to merge 1 commit intomendixlabs:mainfrom
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Conversation
Symptom: describe/exec/describe could not preserve Studio Pro download-file activities because MDL had no statement for Microflows$DownloadFileAction. Root cause: the action was parsed from MPR into the SDK model, but the AST, grammar, visitor, describer, builder, and writer did not expose it as authorable microflow syntax. Fix: add `download file $FileDocument [show in browser]` with normal activity error handling, MPR read/write support, generated parser/completions, proposal docs, quick-reference coverage, and write-microflows skill guidance. Tests: added parser/visitor, builder, formatter, and MPR roundtrip regressions, plus a synthetic doctype fixture. Validated with `make build`, focused Go tests, `mxcli check mdl-examples/doctype-tests/download_file.test.mdl`, `make lint-go`, `make test`, and `make test-integration`.
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #332.
Summary
Adds MDL support for Studio Pro
Microflows$DownloadFileActionusing:The statement preserves existing download-file actions during describe/exec/describe and makes the action authorable when the file document variable already exists.
Root Cause
DownloadFileActionwas recognized by the MPR parser, but MDL had no AST node, grammar rule, visitor builder, describer output, graph builder, or writer support for it. Existing actions therefore could not round-trip as structured MDL.Changes
DownloadFileStmtto the microflow AST.download file $Var [show in browser] [on error ...]grammar and visitor support.Microflows$DownloadFileActionobjects withErrorHandlingType,FileDocumentVariableName, andShowInBrowserpreserved.Validation
make buildgo test ./mdl/visitor ./mdl/executor ./sdk/mpr -run 'TestDownloadFile|TestFormatAction_DownloadFile|TestBuildFlowGraph_DownloadFileCreatesRealAction'./bin/mxcli check mdl-examples/doctype-tests/download_file.test.mdlmake lint-gomake testmake test-integrationAgentic Code Testing